Programming exercises: Fix an issue when editing build scripts

[reschandreas]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.

Changes affecting Programming Exercises

• High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
• I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.
• I tested all changes and their related features with all corresponding user types on a test server configured with Bitbucket and Bamboo.

Motivation and Context

Due to a small bug in the storing and editing code in the server the build script was not always stored correctly, this PR fixes that.

Description

I store the build script after adding it by saving the programming exercise.

Steps for Testing

Prerequisites:

• 1 Instructor

1. Log in to Artemis
2. Create a programming exercise with a custom build script
3. Save, and go to edit -> the default build script should be there

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

• Refactor
  • Enhanced the backend logic for programming exercises, including updates to handling of files and build configurations.
  • Improved integration with auxiliary repositories and submission policies.
  • Added new service classes for exercise specifications, participation, profiles, and submission policies.
  • Updated imports and declarations for better code organization.

[coderabbitai]

Walkthrough

The updates made to the programming exercise service encompass a comprehensive overhaul aimed at enhancing functionality and streamlining processes. These changes include integrating various Java utility classes, introducing new service classes to bolster existing capabilities, refining the management of key entities like auxiliary repositories, courses, and exercise specifics, and improving logic related to test cases, user interactions, and version control system (VCS) repository URIs.

Changes

Files	Change Summary
ProgrammingExerciseService.java	- Imported utility classes (ArrayList, Arrays, Collection, Collections, List, Objects, Optional). - Modified declarations for AuxiliaryRepository, Course, ProgrammingExercise, ProgrammingExerciseTestCase, Repository, User, VcsRepositoryUri, and various enumerations. - Added service classes: ExerciseSpecificationService, ParticipationService, ProfileService, SubmissionPolicyService. - Updated logic for handling windfiles and build plan configurations.
ProgrammingExerciseStudentParticipationRepository.java	The change introduces an additional condition in the unsetBuildPlanIdForExercise method to only update the buildPlanId and initializationState for participations with a specific exerciseId and InitializationState.INITIALIZED.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[laurenzfb]

tested on ts3, code lgtm

[rstief]

Code 👍

[milljoniaer]

tested, works as expected 👍

[github-actions]

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test3.artemis.cit.tum.de" is already in use by PR #8110.

[milljoniaer]

tested locally, works as expected

[mateusmm01]

Code lgtm

[laurenzfb]

reapprove after changes

[krusche]

Code looks good to me