Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add database changes for standardized competencies #8284

Conversation

rstief
Copy link
Contributor

@rstief rstief commented Apr 1, 2024

🚨 DO NOT DEPLOY TO TS1!!! IT WILL BREAK 🚨

Checklist

General

Motivation and Context

Add the database changelog for standardized competencies in 6.9.X so Artemis can have a single initial database schema for 7.0.0

Description

Adds the database changelog for standardized competencies

Steps for Testing

See that the migration checks succeed and that Artemis starts.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

unchanged

Summary by CodeRabbit

  • New Features

    • Version update to Artemis-6.9.6 with enhanced functionality.
    • New methods for handling build logs, including saving, retrieving, and deleting.
    • Added capability to check if an exercise has started.
    • New endpoints for retrieving logs availability for results and canceling all running build jobs for a specific agent.
    • Updated logic for authorization and handling of plagiarism submissions.
    • Introduction of ImportOptions for programming exercises update component.
    • Added display for build logs availability in participation submission component.
  • Bug Fixes

    • Adjusted SQL query references and conditions in guidelines documentation.
    • Refactored queries in repositories for improved efficiency and clarity.
    • Fixed exception handling during Docker image pulling process.
  • Refactor

    • Updated various classes and methods to use new BuildStatus enum.
    • Simplified file retrieval logic in RepositoryResource.
    • Removed unnecessary properties and dependencies in several services and models.
    • Improved synchronization and cancellation handling in build job management services.
  • Documentation

    • Updated README and developer guidelines to reflect new changes and features.
  • Style

    • Adjusted bindings and checkboxes in update components for programming exercises.
  • Chores

    • Updated project version and dependencies in build configuration files.

@rstief rstief requested a review from a team as a code owner April 1, 2024 19:20
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) documentation database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. config-change Pull requests that change the config in a way that they require a deployment via Ansible. labels Apr 1, 2024
@rstief rstief changed the base branch from develop to release/6.9.x April 1, 2024 19:20
@rstief rstief removed tests server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) documentation config-change Pull requests that change the config in a way that they require a deployment via Ansible. labels Apr 1, 2024
Copy link

coderabbitai bot commented Apr 1, 2024

Walkthrough

This update focuses on enhancing the Artemis application by upgrading dependencies, refining the database schema, improving local continuous integration (CI) and version control system (VCS) configurations, and extending functionality across several areas including plagiarism detection, exercise management, and repository services. It introduces more efficient data handling, better access control, and streamlined processes for handling build jobs and submissions, aiming to improve both the developer and user experience within the platform.

Changes

Files Change Summary
README.md, build.gradle, gradle.properties, gradle/liquibase.gradle Updated project and dependency versions, including Artemis and Liquibase.
docs/dev/.../criteria-builder.rst, src/main/java/.../domain/User.java, src/main/java/.../domain/UserGroup.java, src/main/java/.../domain/PersistentAuditEvent.java, src/main/java/.../domain/plagiarism/PlagiarismResult.java Updated database schema and SQL queries for improved data handling and naming conventions.
src/main/java/.../config/localvcci/LocalCIConfiguration.java, src/main/java/.../service/connectors/localci/..., src/main/java/.../service/connectors/localvc/LocalVCServletService.java, src/main/java/.../domain/BuildJob.java, src/main/java/.../domain/enumeration/BuildStatus.java Enhanced local CI and VCS configurations, including build job status updates and error handling improvements.
src/main/java/.../service/ExerciseDateService.java, src/main/java/.../service/RepositoryAccessService.java, src/main/java/.../service/RepositoryParticipationService.java, src/main/java/.../service/RepositoryService.java, src/main/java/.../service/ResultService.java, src/main/java/.../web/rest/ResultResource.java Added and refined services for exercise management, repository access, and result handling.
src/main/java/.../repository/metis/conversation/GroupChatRepository.java, src/main/java/.../repository/metis/conversation/OneToOneChatRepository.java, src/main/java/.../service/metis/conversation/ConversationService.java, src/main/java/.../service/metis/conversation/OneToOneChatService.java Improved chat functionality with better data retrieval and handling.
src/main/webapp/app/..., src/main/java/.../web/rest/... UI and API updates to support new features and changes in backend services.

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB changes

@rstief
Copy link
Contributor Author

rstief commented Apr 3, 2024

See also Changelog in #8129

@krusche krusche modified the milestones: 7.0.0, 6.9.6 Apr 3, 2024
@krusche krusche merged commit 80c42d4 into release/6.9.x Apr 3, 2024
24 of 29 checks passed
@krusche krusche deleted the feature/development/add-standardized-competency-changelog branch April 3, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants