-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Cache dependencies in the Java blackbox template
#8351
Conversation
.mvn is falsely detected as a file to copy.
The solution with the docker volumns is not necessary anymore with the maven proxy approach. Uncomment with some explanation if somebody prefer this caching approach.
Link to documentation, where more details will be available.
Last option needs further system configuration, so not active by default. Mention docs for further information.
Change to method name "setup()" for fitting with template using this artemis/src/main/resources/templates/jenkins/java/blackbox/regularRuns/pipeline.groovy
Have to be called "code-block" instead of "code" + correct ident
+ restore caption build.gradle
Sphinx does print listitems with subitems complitly bold, so switch to italic to emphasize.
There was a empty line missing above the section header, because of the line above, which was added in the Review process.
WalkthroughThe update focuses on enhancing Maven dependency handling and security in programming exercises setup. It includes instructions for caching Maven dependencies via Sonatype Nexus, security considerations for Jenkins setups, and updates to directory filtering and Maven configuration for improved performance and security measures. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Corresponding to the Exam Mode parts of the Pull Request template: Does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code/documentation review: Looks good apart from two minor things. 👍
Programming exercises
: Show new caching approach in Artemis Dejagnu templates and documente approachProgramming exercises
: Document new Maven dependency caching approach and apply it to the Java blackbox template
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demonstrated during testing session; LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during testing session, works as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested during testing session on legacy ts2, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during testing session, works as described
Programming exercises
: Document new Maven dependency caching approach and apply it to the Java blackbox templateProgramming exercises
: Cache dependencies in the Java blackbox template
Checklist
General
Server
Client
No Changes at the client
Changes affecting Programming Exercises
High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).Only applicable to the GitLab/Jenkins template. The Aeolus/LocalCI one does not support setting Docker run flags specific to the exercise.Motivation and Context
The actual caching approach with Docker volumes has one mature disadvange.
It needs to have a testing run for the solution before a testing run for a student submission
on each host, which is running the containers.
That is a problem if you need more hosts to run the container because of scaling issues.
The new approach uses a dedicated cache server (Maven proxy) that does not have this limitation.
Description
Steps for Testing
Prerequisites:
Java
DejaGnu
The updated documentation can be found at https://artemis-platform--8351.org.readthedocs.build/en/8351/admin/setup/programming-exercises.html#caching-maven-dependencies-with-sonatype-nexus
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Only trivial change in java code.