Programming exercises: Reject results without commit hash

[Strohgelaender]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
• I documented the Java code using JavaDoc style.

Motivation and Context

There recently was a case where due to an error in the external CI system, Artemis would recive result notifications without any commit hash. Without a commit hash Artemis is unable to select a submission to link the result to, leading to unexpected behaviour (the creation of multiple fallback submissions).

Description

We now immedetly reject results if they do not contain a assignment commit hash.

Steps for Testing

code review, this is not really testable since this was caused by a faulty external system. You can check that the normal result processing still works.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

test added, all new branches covered.

[coderabbitai]

Walkthrough

This update introduces enhancements in the handling of build notifications without a commit hash in programming exercises, ensuring that such notifications are properly rejected to maintain the integrity of the grading process.

Changes

File Path	Change Summary
.../programming/ProgrammingExerciseGradingService.java	Added a method to check for commit hash presence in build notifications and reject processing if it's missing.
.../programmingexercise/ProgrammingExerciseResultJenkinsIntegrationTest.java	New test to ensure notifications without a commit hash are rejected.
.../programmingexercise/ProgrammingExerciseResultTestService.java	Added test for rejecting notifications lacking a commit hash.

Possibly related issues

• Exam: Divide the Testing Process into Steps #6621: The emphasis on precise handling of build notifications could indirectly contribute to the robustness of test case execution and management during exam programming exercises, aligning with the goal of preventing misconfigurations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julian-christl]

code

[BaumiCoder]

Successful tested on artemis-test5. I made some submissions with artemis_test_user_3 in the online editor, also one with passing the tests.

[pzdr7]

Tested on TS1 with a programming exercise. Got a result ✅