Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add documentation for production setup using Docker #8400

Merged
merged 16 commits into from
May 5, 2024

Conversation

BBesrour
Copy link
Member

@BBesrour BBesrour commented Apr 14, 2024

Checklist

General

Motivation and Context

Updates the 'Multiple Artemis Instances' docs to include instructions for a production setup using docker. This is intended for developers and admins to quickly test the prod env.

Description

Added instructions to start Multiple Artemis Instances for Linux, Windows, and MacOS using docker. Also added instructions on how to run a setup with separated core and buildagent instances.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

image
image

Summary by CodeRabbit

  • Documentation

    • Updated setup documentation for running multiple Artemis instances locally using Docker, including detailed instructions for various operating systems.
  • New Features

    • Enhanced version control integration with new environment variables for user authentication in node configurations.
  • Refactor

    • Modified Spring profiles in node configuration to optimize service roles.
    • Updated version control URL to improve connectivity between nodes.
  • Chores

    • Streamlined load balancing by adjusting the upstream server configuration in Nginx.

@BBesrour BBesrour self-assigned this Apr 14, 2024
@BBesrour BBesrour marked this pull request as ready for review April 14, 2024 11:16
@BBesrour BBesrour requested a review from a team as a code owner April 14, 2024 11:16
Copy link

coderabbitai bot commented Apr 14, 2024

Walkthrough

The updates focus on enhancing the Artemis setup for distributed environments using Docker. Changes include configuring Artemis instances, modifying environment variables, and adjusting the load balancer setup. The alterations streamline profiles and update version control settings, aiming to optimize the system for different operational roles and improve connectivity between nodes.

Changes

Files Change Summary
docs/admin/setup/distributed.rst Documented the setup process for Artemis in a distributed environment using Docker.
docker/artemis/config/node1.env Removed buildagent from SPRING_PROFILES_ACTIVE.
docker/artemis/config/node2.env Added version control user and password environment variables.
docker/artemis/config/node3.env Updated Spring profiles and added version control credentials.
docker/artemis/config/prod-multinode.env Updated the ARTEMIS_VERSIONCONTROL_URL to point to a new node.
docker/nginx/.../artemis-upstream-multi-node.conf Removed configuration for artemis-app-node-3:8080 from the upstream server list.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@BBesrour BBesrour changed the title add instructions for multi node setup on linux and windows Development: add instructions for multi node setup on linux and windows Apr 14, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 14, 2024
@BBesrour BBesrour marked this pull request as draft April 16, 2024 14:42
- add instructions for separate profiles
@BBesrour BBesrour changed the title Development: add instructions for multi node setup on linux and windows Development: add docs for production setup using Docker Apr 18, 2024
@BBesrour BBesrour marked this pull request as ready for review April 18, 2024 13:12
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

docker/artemis/config/node2-buildagent.env Outdated Show resolved Hide resolved
@BBesrour BBesrour removed the small label Apr 18, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 19, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 27, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

docker/artemis/config/node3.env Show resolved Hide resolved
docker/artemis/config/prod-multinode.env Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 27, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm. just some minor nitpicks

docs/admin/setup/distributed.rst Outdated Show resolved Hide resolved
docs/admin/setup/distributed.rst Outdated Show resolved Hide resolved
docs/admin/setup/distributed.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a few notes on grammar

docs/admin/setup/distributed.rst Outdated Show resolved Hide resolved
docs/admin/setup/distributed.rst Outdated Show resolved Hide resolved
docs/admin/setup/distributed.rst Outdated Show resolved Hide resolved
@BBesrour BBesrour requested review from laurenzfb and rstief April 29, 2024 15:46
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now :)

Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and documentation looks good to me

Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Great work!

@b-fein b-fein added this to the 7.0.3 milestone May 4, 2024
@krusche krusche modified the milestones: 7.0.3, 7.0.4 May 5, 2024
@krusche krusche changed the title Development: add docs for production setup using Docker Development: Add documentation for production setup using Docker May 5, 2024
@krusche krusche merged commit 1d05ef5 into develop May 5, 2024
29 of 34 checks passed
@krusche krusche deleted the docs/multi-node-setup-with-docker branch May 5, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants