Development: Fix cases of ignored return values
#8575
Merged
GitHub Actions / Java Architecture Tests
succeeded
May 11, 2024 in 0s
50 passed, 0 failed and 0 skipped
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ArchitectureTest.xml
19 tests were completed in 4s with 19 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.architecture.ArchitectureTest | 19✅ | 4s |
✅ de.tum.in.www1.artemis.architecture.ArchitectureTest
✅ ensureSpringComponentsAreProfileAnnotated()
✅ testNoJunitJupiterAssertions()
✅ hasMatchingAuthorizationTestClassBeCorrectlyImplemented()
✅ testFileWriteUsage()
✅ testCorrectStringUtils()
✅ testValidSimpMessageSendingOperationsUsage()
✅ testLogging()
✅ testNoHazelcastUsageInConstructors()
✅ testJSONImplementations()
✅ testNoRestControllersImported()
✅ testNoDirectGitCommitCalls()
✅ testNoCollectorsToList()
✅ testClassNameAndVisibility()
✅ testGsonExclusion()
✅ testNoJUnit4()
✅ shouldNotUserAutowiredAnnotation()
✅ testCorrectLoggerFields()
✅ testJsonIncludeNonEmpty()
✅ testNullnessAnnotations()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest.xml
2 tests were completed in 190ms with 2 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest | 2✅ | 190ms |
✅ de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest
✅ testEnforceRoleInExerciseEndpointHasExerciseIdParameter()
✅ testEnforceRoleInCourseEndpointHasCourseIdParameter()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest.xml
2 tests were completed in 318ms with 2 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest | 2✅ | 318ms |
✅ de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest
✅ testSetLongFeedbackTextNotUsed()
✅ testGetLongFeedbackTextNotUsed()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest.xml
9 tests were completed in 304ms with 9 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest | 9✅ | 304ms |
✅ de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest
✅ testNoEntityGraphsOnQueries()
✅ testNoUnusedRepositoryMethods()
✅ testTransactional()
✅ shouldBeInRepositoryPackage()
✅ testRepositoryParamAnnotation()
✅ persistenceShouldNotAccessServices()
✅ testJPQLStyle()
✅ shouldBeNamedRepository()
✅ testOnlySpringTransactionalAnnotation()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ResourceArchitectureTest.xml
4 tests were completed in 81ms with 4 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.architecture.ResourceArchitectureTest | 4✅ | 81ms |
✅ de.tum.in.www1.artemis.architecture.ResourceArchitectureTest
✅ allPublicMethodsShouldReturnResponseEntity()
✅ shouldBeNamedResource()
✅ shouldBeInResourcePackage()
✅ shouldCorrectlyUseRequestMappingAnnotations()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ServiceArchitectureTest.xml
4 tests were completed in 150ms with 4 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.architecture.ServiceArchitectureTest | 4✅ | 150ms |
✅ de.tum.in.www1.artemis.architecture.ServiceArchitectureTest
✅ shouldBeNamedService()
✅ testCorrectServiceAnnotation()
✅ shouldBeInServicePackage()
✅ testNoWrongServiceImports()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest.xml
8 tests were completed in 88ms with 8 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest | 8✅ | 88ms |
✅ de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest
✅ testEnforceAdminAnnotations()
✅ testEnforceAtLeastEditorAnnotations()
✅ testNoPreAuthorizeOnRestEndpoints()
✅ testEnforceAtLeastTutorAnnotations()
✅ testEnforceAtLeastInstructorAnnotations()
✅ testEnforceAtLeastStudentAnnotations()
✅ testEnforceNothingAnnotations()
✅ testNoPreAuthorizeOnRestControllers()
✅ build/test-results/test/TEST-de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest.xml
2 tests were completed in 41ms with 2 passed, 0 failed and 0 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest | 2✅ | 41ms |
✅ de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest
✅ testNotificationPlaceholderCreatorStringArrayCreation()
✅ testPlaceholderCreatorMethodSignature()
Loading