-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Move the open repository buttons to the new code popup
#8920
Programming exercises
: Move the open repository buttons to the new code popup
#8920
Conversation
…vigation' into chore/programming-exercises/remove-open-repository-buttons
Programming exercises
: Move the open repository button to the clone popupProgramming exercises
: Move the open repository buttons to the clone popup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS1 all Steps for a normal programming Exercise and then created an exam with a programming exercise and tested it aswell. Everything works as expected and I like the changes 😄 . Code LGTM aswell 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove code. Also looked at the documentation changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approve, docs lgtm
…epository-buttons
Programming exercises
: Move the open repository buttons to the code popupProgramming exercises
: Move the open repository buttons to the new code popup
…epository-buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes, works well 👍
Checklist
General
Client
Changes affecting Programming Exercises
Motivation and Context
Description
Steps for Testing
Prerequisites:
Student view (for easier testing, do this step as an instructor. you will need instructor access for the steps later)
Instructor: Exercise participations:
Instructor: Exercise scores
Instructor: Template/Solution/Tests repos:
Instructor: Manual assessment example solution
Exam Mode Testing
Prerequisites:
Student participation and summary
Instructor: summary
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Only non-trivial changes in .ts files; the rest of the changes are in either the playwright tests or HTML templates
Screenshots
Student view (regular)
Before
After
The repository view can now be accessed via the button in the popup:
Instructor: Exercise participations
Before
After
Instructor: Exercise scores
Before
After
Tutor/Instructor: Example solution (manual assessment)
Before
After
Exam participation / summary
Before
Participation
Summary
After
Participation
Summary
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Localization