Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Add links to citations for lecture questions #9019

Merged
merged 11 commits into from
Dec 10, 2024

Conversation

yassinsws
Copy link
Contributor

@yassinsws yassinsws commented Jul 11, 2024

Checklist

General

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).

Motivation and Context

Right now Iris answers with the lecture and the page it got it's answer from. This lacks usability. Thus I added links to make a better user experience,

Description

Iris now answers with links to the corresponding letures it got its' answers from.

Steps for Testing

Prerequisites:

  • 1 Test server with Iris enabled
  • 1 Course with lecture ingested in it.
  • 1 Student/ Instructor
  1. Log in to Artemis as the student where Iris is enabled.
  2. Go to the course dashboard and ask a question like "explain me the content of lecture 1"
  3. The answer of the chatbot should have citations like the screenshot below.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.



Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Only trivial changes in server file.

Screenshots

image

Summary by CodeRabbit

  • New Features
    • Added lectureUnitLink to lecture unit updates and deletions, providing additional context in notifications.

@yassinsws yassinsws requested a review from a team as a code owner July 11, 2024 11:08
Copy link

coderabbitai bot commented Jul 11, 2024

Walkthrough

The update introduces a new field, lectureUnitLink, to the PyrisLectureUnitWebhookDTO class, enhancing the data structure to include additional information about lecture units. This change impacts the methods processAttachmentForUpdate and processAttachmentForDeletion within the PyrisWebhookService, which now pass the lectureUnitLink parameter when constructing the DTO.

Changes

File Change Summary
src/main/java/de/tum/in/www1/artemis/service/connectors/pyris/PyrisWebhookService.java Updated processAttachmentForUpdate and processAttachmentForDeletion to handle lectureUnitLink.
src/main/java/de/tum/in/www1/artemis/service/connectors/pyris/dto/lectureingestionwebhook/... Added new field lectureUnitLink to the PyrisLectureUnitWebhookDTO class.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Jul 11, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 11, 2024
JohannesStoehr
JohannesStoehr previously approved these changes Jul 11, 2024
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@krusche krusche changed the title Add links to citations on Iris Lecture Chat Pipeline Iris: Add links to citations for lecture questions Jul 12, 2024
edkaya
edkaya previously approved these changes Jul 12, 2024
Copy link
Contributor

@edkaya edkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

egekurt123
egekurt123 previously approved these changes Jul 13, 2024
Copy link
Contributor

@egekurt123 egekurt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmytropolityka
dmytropolityka previously approved these changes Jul 15, 2024
Copy link
Contributor

@dmytropolityka dmytropolityka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 25, 2024
@github-actions github-actions bot closed this Aug 8, 2024
@bassner bassner reopened this Aug 27, 2024
Copy link

github-actions bot commented Sep 6, 2024

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 6, 2024
@github-actions github-actions bot closed this Sep 21, 2024
@bassner bassner reopened this Dec 9, 2024
@github-actions github-actions bot added the iris Pull requests that affect the corresponding module label Dec 9, 2024
@github-actions github-actions bot added the tests label Dec 10, 2024
@bassner bassner merged commit dfc4f80 into develop Dec 10, 2024
19 of 21 checks passed
@bassner bassner deleted the feature/iris/addLinksToCitations branch December 10, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iris Pull requests that affect the corresponding module server Pull requests that update Java code. (Added Automatically!) stale tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants