Communication: Fix background color issue for pinned messages

[egekurt123]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I added multiple screenshots/screencasts of my UI changes.

Description

This pull request addresses a bug that prevented the background color of pinned messages from changing as intended.

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Course with Communication enabled

1. Log in to Artemis
2. Navigate to Course Communication
3. Write a message
4. Pin the message
5. Make sure that the background color of the message changes.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Screenshots

Day mode

Dark mode

Summary by CodeRabbit

• Style

  • Updated the CSS class .highlight-pinned to use background-color for pinned posts, enhancing visual distinction.

• New Features

  • Added conditional class binding to highlight pinned posts based on their priority in the post component.

• Refactor

  • Modified import statements and removed unused imports to streamline code structure and improve maintainability.

• Chores

  • Simplified the HTML structure of the posting thread component by removing unnecessary conditional class assignments.

[coderabbitai]

Walkthrough

The primary changes involve updating the CSS and HTML templates to improve the visual differentiation of pinned posts in the Metis forum. The CSS class for pinned posts is adjusted, and conditional class bindings are added to reflect post priority. Additionally, there are updates to import statements in the TypeScript files to align with changes in the utility imports.

Changes

Files	Change Summary
src/main/webapp/app/shared/metis/metis.component.scss	Changed the background property to background-color for the .highlight-pinned class.
src/main/webapp/app/shared/metis/post/post.component.html	Added a conditional class highlight-pinned based on posting.displayPriority.
src/main/webapp/app/shared/metis/post/post.component.ts	Updated import from PageType to DisplayPriority.
src/main/webapp/app/shared/metis/posting-thread/posting-thread.component.html	Removed the conditional class assignment based on post.displayPriority.
src/main/webapp/app/shared/metis/posting-thread/posting-thread.component.ts	Removed the import of DisplayPriority from metis.util.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[asliayk]

tested locally both on light & dark mode, works as expected.

[EneaGore]

Tested on TS5, works as expected

[edkaya]

Tested in the testing session, works as expected. Code lgtm