-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix LTI on multi node systems
#9085
Conversation
…gfix/lit-multinode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I like the logging you did here. However, I'm not sure if all of it should be logged as info?
I had it at debug it first, but Stephan requested it to be in info level. LTI is not used often (which makes it a prime candidate for some regressions to sneak in) and in these cases gaining information about the LTI process should be as simple as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look at the code, but tested the PR on the staging server and it now works as expected 👍
Development
: Fix LTI on multinode systemsGeneral
: Fix LTI on multinode systems
General
: Fix LTI on multinode systemsDevelopment
: Fix LTI on multi node systems
Checklist
General
Server
Motivation and Context
LTI does not work on multinode setups.
Fixes #9017.
Description
I copied the code of the default
StateAuthorizationRequestRepository
(which sadly is a final class) into a newDistributedStateAuthorizationRequestRepository
that now uses Hazelcast to share the content between nodes.Steps for Testing
Use a multinode testserver like TS3 (see https://confluence.ase.in.tum.de/pages/viewpage.action?pageId=25252245).
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Summary by CodeRabbit
New Features
Improvements
Bug Fixes