-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Enhance coverage report script
#9153
Conversation
WalkthroughThe recent changes enhance both the documentation and the code structure of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant GitRepo
User->>Script: Execute script with options
Script->>GitRepo: Validate repository path
alt Valid Path
Script->>GitRepo: Get branch name
Script->>GitRepo: Retrieve changed files
Script->>User: Print results
else Invalid Path
Script-->>User: Log error message
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 12
Outside diff range comments (1)
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py (1)
Line range hint
154-179
:
LGTM! Add type annotations for better readability.The function signature change is appropriate, but adding type annotations would improve readability.
- def get_changed_files(repo_path, branch_name, base_branch_name="origin/develop"): + def get_changed_files(repo_path: str, branch_name: str, base_branch_name: str = "origin/develop") -> dict:
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
b40e734
to
c98e6eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the improvement ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on Windows 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, works fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, thanks for the changes improving the code coverage script :)
Checklist
General
Motivation and Context
The script for generating coverage reports was somewhat cumbersome to use.
Description
--repo-path
option.Steps for Testing
Execute the script at
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
at different working directives inside the repo.Execute the script from outside the repo specifying a path to the repo with the
--repo-path
option.Review Progress
Code Review
Manual Tests
Summary by CodeRabbit
Documentation
README.md
with clearer instructions, including a new "Printing" section for direct command line output.Bug Fixes
Refactor