-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix regex in GitHub test action to only find truly failed test cases
#9189
Conversation
WalkthroughThe recent changes enhance the accuracy of test failure detection in GitHub Actions workflows. By refining the regular expressions used in Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI/CD Pipeline
participant Test as Test Runner
participant Log as Logs
CI->>Test: Trigger Test Execution
Test->>Log: Log Test Results
Log->>CI: Output Logs
CI->>CI: Check for "Test >.* FAILED$"
alt If Test Failed
CI->>CI: Report Failure
else
CI->>CI: No Action
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Development
: Fix regex in GH test action to only find truly failed test casesDevelopment
: Fix regex in GitHub test action to only find truly failed test cases
Checklist
General
Motivation and Context
Currently, the GH test action always fails due to the regex also finding false positives:
Description
This PR updates the regex and appends an end-of-string check (
$
) to it.Steps for Testing
Look into the output of this PR's GH server-test action and confirm that the two false positives from the screenshot above are not shown anymore.
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit