Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lectures: Add bottom padding in course details #9196

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JohannesWt
Copy link
Contributor

@JohannesWt JohannesWt commented Aug 6, 2024

Checklist

General

Client

Motivation and Context

If a lot of lecture units are displayed in the course-lecture-details page the last lecture unit is aligned with the bottom of the page.

Description

This PR adds a small padding to the lecture unit list in the course detail page so that the last lecture unit has some space to the bottom of the page.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

unchanged

Summary by CodeRabbit

  • New Features

    • Enhanced visual presentation of lecture details with improved spacing and alignment.
  • Style

    • Adjusted padding and margin properties for better readability and layout cohesion within the course lecture details.

@JohannesWt JohannesWt self-assigned this Aug 6, 2024
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Aug 6, 2024
@JohannesWt JohannesWt temporarily deployed to artemis-test5.artemis.cit.tum.de August 6, 2024 18:45 — with GitHub Actions Inactive
@JohannesWt JohannesWt marked this pull request as ready for review August 6, 2024 18:48
@JohannesWt JohannesWt requested a review from a team as a code owner August 6, 2024 18:48
Copy link

coderabbitai bot commented Aug 6, 2024

Walkthrough

The recent modifications enhance the visual presentation of the course lecture details by refining spacing and alignment within the HTML structure. Key adjustments include increased padding for improved readability, margin resets for better alignment, and the removal of padding to optimize space utilization. These changes collectively contribute to a more cohesive and user-friendly interface.

Changes

Files Change Summary
src/main/webapp/app/overview/course-lectures/... Adjusted padding and margin properties to enhance layout and readability.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link
Contributor

@edkaya edkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1.

Before:

image

After:

image

Lgtm 👍

@JohannesWt JohannesWt changed the title Lectures : Add bottom padding in course details Lectures: Add bottom padding in course details Aug 8, 2024
Copy link
Contributor

@Jan-Thurner Jan-Thurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1. LGTM

Copy link
Contributor

@sarpsahinalp sarpsahinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested locally!

Copy link
Contributor

@rabeatwork rabeatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer approve

@pzdr7 pzdr7 added the maintainer-approved The feature maintainer has approved the PR label Aug 16, 2024
@krusche krusche added this to the 7.5.1 milestone Aug 21, 2024
@krusche krusche merged commit 360027f into develop Aug 21, 2024
91 of 95 checks passed
@krusche krusche deleted the bugfix/add-bottom-padding-to-lecture-units-list branch August 21, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) maintainer-approved The feature maintainer has approved the PR ready to merge small
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants