-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Disable Eureka for single node setups
#9198
Development
: Disable Eureka for single node setups
#9198
Conversation
Infrastructure
: Disable Eureka discovery for singlenode setups
Infrastructure
: Disable Eureka discovery for singlenode setupsInfrastructure
: Disable Eureka discovery for single node setups
Infrastructure
: Disable Eureka discovery for single node setupsInfrastructure
: Disable Eureka for single node setups
WalkthroughThe update introduces a new configuration file, Changes
Sequence Diagram(s)sequenceDiagram
participant Service
participant Eureka
Service->>Eureka: Register Service (disabled)
Service->>Eureka: Fetch Service Registry (disabled)
Note over Service: Operates independently without registration or fetching
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS4. Logs are no longer flooded with Eureka messages 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Infrastructure
: Disable Eureka for single node setupsDevelopment
: Disable Eureka for single node setups
Checklist
General
Motivation and Context
See: #8693
Description
We need the same change as in #8693 also for the test servers, so that there are no misleading errors in the logs.
We added the configuration in the global docker configuration as this is not a special configuration option, but rather should be the default for single node docker setups.
Steps for Testing
DiscoveryClient_ARTEMIS/Artemis:1 - was unable to send heartbeat!
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit