Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Disable Eureka for single node setups #9198

Conversation

bensofficial
Copy link
Member

@bensofficial bensofficial commented Aug 7, 2024

Checklist

General

Motivation and Context

See: #8693

Description

We need the same change as in #8693 also for the test servers, so that there are no misleading errors in the logs.

We added the configuration in the global docker configuration as this is not a special configuration option, but rather should be the default for single node docker setups.

Steps for Testing

  1. Deploy to TS2 or TS4
  2. Open the server logs in Grafana (https://grafana.gchq.ase.in.tum.de/d/uBBKO8qnk/nodes-detailed-view?orgId=1&refresh=10s&var-DS_PROMETHEUS=default&var-job=artemis_test&var-name=artemis-test4.artemis.cit.tum.de&var-node=artemis-test-vm4.artemis.cit.tum.de&var-port=9100) and select the server you have chosen.
  3. Check that there are no errors like: DiscoveryClient_ARTEMIS/Artemis:1 - was unable to send heartbeat!

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • New Features
    • Introduced a configuration file for single-node deployment of the Artemis service, optimizing it for standalone operation.
    • Adjusted settings to prevent the service from registering with the Eureka server and fetching the service registry, enhancing performance and reducing complexity.

@github-actions github-actions bot added the docker label Aug 7, 2024
@bensofficial bensofficial changed the title Disable Eureka discovery for singlenode setups Infrastructure: Disable Eureka discovery for singlenode setups Aug 7, 2024
@bensofficial bensofficial changed the title Infrastructure: Disable Eureka discovery for singlenode setups Infrastructure: Disable Eureka discovery for single node setups Aug 7, 2024
@bensofficial bensofficial changed the title Infrastructure: Disable Eureka discovery for single node setups Infrastructure: Disable Eureka for single node setups Aug 7, 2024
@bensofficial bensofficial marked this pull request as ready for review August 7, 2024 12:06
@bensofficial bensofficial requested a review from a team as a code owner August 7, 2024 12:06
Copy link

coderabbitai bot commented Aug 7, 2024

Walkthrough

The update introduces a new configuration file, prod-singlenode.env, for the Artemis service, optimizing it for a single-node deployment. This file disables service registration and registry fetching with the Eureka server, streamlining operations in standalone scenarios. By avoiding unnecessary network interactions, the configuration enhances performance and simplifies the service’s deployment, making it suitable for testing and specific production environments where service discovery is not required.

Changes

File Path Change Summary
docker/artemis/config/prod-singlenode.env Added configuration parameters: EUREKA_CLIENT_REGISTERWITHEUREKA=false, EUREKA_CLIENT_FETCHREGISTRY=false.

Sequence Diagram(s)

sequenceDiagram
    participant Service
    participant Eureka

    Service->>Eureka: Register Service (disabled)
    Service->>Eureka: Fetch Service Registry (disabled)
    Note over Service: Operates independently without registration or fetching
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS4. Logs are no longer flooded with Eureka messages 👍

Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works 👍🏻

Copy link
Contributor

@iyannsch iyannsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krusche krusche changed the title Infrastructure: Disable Eureka for single node setups Development: Disable Eureka for single node setups Aug 8, 2024
@krusche krusche added this to the 7.5.0 milestone Aug 8, 2024
@krusche krusche merged commit 59aeaab into develop Aug 8, 2024
42 of 46 checks passed
@krusche krusche deleted the bugfix/infrastructure/disable-eureka-discovery-for-single-node-setups branch August 8, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants