-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Fix scroll to section when clicking status bar in exercise update view
#9243
General
: Fix scroll to section when clicking status bar in exercise update view
#9243
Conversation
Programming exercises
: Fix scroll to headline from scroll status bar
WalkthroughThe updates include modifications to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Programming exercises
: Fix scroll to headline from scroll status barProgramming exercises
: Fix scroll to section when clicking status bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Outside diff range comments (1)
src/test/javascript/spec/component/forms/form-status-bar.component.spec.ts (1)
Line range hint
1-30
: Consider re-adding a basic initialization test.While the focus is on core functionality, a basic test to ensure the component initializes correctly can be beneficial for catching setup issues early.
Consider re-adding a simple test like:
it('should create', () => { expect(comp).toBeDefined(); });
src/main/webapp/app/forms/form-status-bar/form-status-bar.component.ts
Outdated
Show resolved
Hide resolved
...test/playwright/support/pageobjects/exercises/programming/ProgrammingExerciseCreationPage.ts
Outdated
Show resolved
Hide resolved
src/test/playwright/e2e/exercise/programming/ProgrammingExerciseManagement.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code 👍
…adline-from-scroll-status-bar # Conflicts: # src/test/javascript/spec/component/exam/manage/exams/exam-detail.component.spec.ts
07b372b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again on TS1 on Safari, works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reaprove after merge conflict. Still works on Arc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove after merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove Code 👍
…adline-from-scroll-status-bar
…adline-from-scroll-status-bar
…adline-from-scroll-status-bar
…adline-from-scroll-status-bar
…adline-from-scroll-status-bar
…adline-from-scroll-status-bar
…adline-from-scroll-status-bar
Checklist
General
Client
Motivation and Context
When using the scroll functionality from the formStatusBar in the programming exercise update view (create/edit/import) the page scrolls too far, so the headline will not be seen.
This PR fixes the scrolling, so now the headline of the section will be finished when the scrolling is done.
Description
Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Screenshots
old (broken version)
Headline not visible after scroll
Safari
The FormStatusBar disappears
new (fixed version)
Headline visible after scroll
Safari
The FormStatusBar does not disappear anymore
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Refactor
Tests