Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update version of micrometer prometheus package #9255

Merged

Conversation

bensofficial
Copy link
Member

@bensofficial bensofficial commented Aug 29, 2024

Checklist

General

Motivation and Context

Some time ago, there were problems with the update of the io.micrometer:micrometer-registry-prometheus package.

These problems were probably caused by some incompatibility with Spring. As they are resolved now, we can update the micrometer-registry-prometheus package.

Description

Updates the version of the io.micrometer:micrometer-registry-prometheus package.

Steps for Testing

  1. Deploy to Staging (if not deployed yet).
  2. Open the Artemis Statistics for Staging Local CI in Grafana: https://grafana.gchq.ase.in.tum.de/d/d9vRDInMa/artemis-statistics
  3. Check that the monitoring panels look reasonable and that there is no panel with No data.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Chores
    • Updated the Micrometer Prometheus registry dependency to the latest version, ensuring improved performance and potential new features for metrics integration.

@bensofficial bensofficial requested a review from a team as a code owner August 29, 2024 15:23
Copy link

coderabbitai bot commented Aug 29, 2024

Walkthrough

The change involves updating the version of the micrometer-registry-prometheus dependency in the build.gradle file from 1.12.6 to 1.13.3. This update reflects a transition to a newer library version, which may include various improvements and fixes.

Changes

Files Change Summary
build.gradle Updated micrometer-registry-prometheus from version 1.12.6 to 1.13.3.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bensofficial bensofficial added ready for review dependencies Pull requests that update a dependency file labels Aug 29, 2024
@iyannsch iyannsch self-requested a review August 29, 2024 15:52
@iyannsch
Copy link
Contributor

The GH action responsible for deploying the PR content on the staging instance seems to stop after scanning/reading the labels here. Could you make sure that the deploy is possible please?
Also, would you mind providing the URL for the staging instance? staging.artemis.cit.tum.de and artemis-staging-localci.artemis.cit.tum.de (my first tries) do not seem to work

@bensofficial
Copy link
Member Author

bensofficial commented Aug 29, 2024

@iyannsch You cannot deploy to Staging using GitHub Actions, but must use Bamboo instead.
The URL is: https://artemis-staging-localci.artemis.cit.tum.de/

It is also documented in Confluence: https://confluence.ase.in.tum.de/x/lVGBAQ

@krusche krusche changed the title Development: Update version of Micrometer Prometheus package Development: Update version of micrometer prometheus package Aug 30, 2024
@krusche krusche added this to the 7.5.1 milestone Aug 30, 2024
@krusche krusche merged commit f726b93 into develop Aug 30, 2024
41 of 45 checks passed
@krusche krusche deleted the chore/update-micrometer-registry-prometheus-version branch August 30, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants