-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Enable empty template for LocalCI
#9280
Merged
krusche
merged 13 commits into
develop
from
feature/programming-exercises/empty-template-localci-and-ui
Sep 20, 2024
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1f9f9ed
Enable Empty Template for LocalCI
magaupp 9a76092
Empty Template usage hints
magaupp cbb56fb
Add TODOs to build script
magaupp aeba9f5
Add warning icon and enumerate list
magaupp 822fccf
Enable custom build script as default for Empty language
magaupp 4a86e7c
Link to GitHub Container Registry and Docker Hub
magaupp 2539ff2
Resize icon
magaupp 1062fcb
Link to documentation
magaupp 18f3f68
Add TODO comments to Jenkins pipeline
magaupp 8ae97b5
Replace Maven command and add TODO comments to GitLab CI
magaupp 30bcdcf
Merge branch 'develop' into feature/programming-exercises/empty-templ…
magaupp 6a25afd
Grammar: with "the" required dependencies
magaupp 0dbaea4
Grammar: checked out "in"
magaupp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#!/usr/bin/env bash | ||
set -e | ||
export AEOLUS_INITIAL_DIRECTORY=${PWD} | ||
install_dependencies () { | ||
echo '⚙️ executing install_dependencies' | ||
# TODO: Install dependencies not provided by the Docker image | ||
echo 'Install dependencies' | ||
} | ||
|
||
run_tests () { | ||
echo '⚙️ executing run_tests' | ||
# TODO: Run the tests and generate JUnit XMLs | ||
echo 'Hello World' | ||
} | ||
|
||
process_results () { | ||
echo '⚙️ executing process_results' | ||
rm -rf results | ||
mkdir results | ||
# TODO: Move JUnit XMLs into the results directory | ||
} | ||
|
||
main () { | ||
if [[ "${1}" == "aeolus_sourcing" ]]; then | ||
return 0 # just source to use the methods in the subshell, no execution | ||
fi | ||
local _script_name | ||
_script_name=${BASH_SOURCE[0]:-$0} | ||
cd "${AEOLUS_INITIAL_DIRECTORY}" | ||
bash -c "source ${_script_name} aeolus_sourcing; install_dependencies" | ||
cd "${AEOLUS_INITIAL_DIRECTORY}" | ||
bash -c "source ${_script_name} aeolus_sourcing; run_tests" | ||
cd "${AEOLUS_INITIAL_DIRECTORY}" | ||
bash -c "source ${_script_name} aeolus_sourcing; process_results" | ||
} | ||
|
||
main "${@}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
api: v0.0.1 | ||
metadata: | ||
name: Empty | ||
id: empty | ||
description: Provides a starting point | ||
actions: | ||
- name: install_dependencies | ||
script: |- | ||
# TODO: Install dependencies not provided by the Docker image | ||
echo 'Install dependencies' | ||
- name: run_tests | ||
script: |- | ||
# TODO: Run the tests and generate JUnit XMLs | ||
echo 'Hello World' | ||
- name: process_results | ||
script: |- | ||
rm -rf results | ||
mkdir results | ||
# TODO: Move JUnit XMLs into the results directory | ||
results: | ||
- name: junit | ||
path: results/*.xml | ||
type: junit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the PR change the default docker image here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to imply that the tests have to be Java based, so I went with something more basic. You would want to use a custom image anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Nevertheless, I would avoid not needed config changes as it might change workflows for instructors and also it increases the amount of used images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point. But a workflow using the default image of
Empty
and requiring Maven without using theJava
template would be highly unusual.Most of the other images are based on
ubuntu
down the line, so I wouldn't expect much of an increase in disk usage.