-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add test file for script to generate random results when creating large courses locally
#9298
Conversation
WalkthroughThe changes introduce enhancements to the setup process for programming exercises, focusing on generating randomized test cases and utilizing existing exercises. New scripts are implemented to manage test case files by deleting outdated folders and copying new randomized test cases. A new Java test class is added to implement randomized unit tests, and the documentation is updated to provide clearer instructions for users regarding these processes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant TestFiles
User->>Script: Run randomize_results_before.py
Script->>TestFiles: Delete existing folders (behavior, structural)
Script->>TestFiles: Copy RandomizedTestCases.java
User->>Script: Run randomize_results_after.py
Script->>TestFiles: Delete RandomizedTestCases.java if exists
Script->>TestFiles: Copy default template folders
Tip New featuresWalkthrough comment now includes:
Notes:
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional context usedMarkdownlint
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
...pts/course-scripts/quick-course-setup/testFiles-template/randomized/RandomizedTestCases.java
Outdated
Show resolved
Hide resolved
...pts/course-scripts/quick-course-setup/testFiles-template/randomized/RandomizedTestCases.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
...pts/course-scripts/quick-course-setup/testFiles-template/randomized/RandomizedTestCases.java
Show resolved
Hide resolved
...pts/course-scripts/quick-course-setup/testFiles-template/randomized/RandomizedTestCases.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
supporting_scripts/course-scripts/quick-course-setup/randomize_results_after.py
Outdated
Show resolved
Hide resolved
supporting_scripts/course-scripts/quick-course-setup/randomize_results_after.py
Outdated
Show resolved
Hide resolved
supporting_scripts/course-scripts/quick-course-setup/randomize_results_before.py
Outdated
Show resolved
Hide resolved
supporting_scripts/course-scripts/quick-course-setup/randomize_results_before.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally and worked as explained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for adding my suggestion!
3ea94d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally and still works as explained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
… creating large courses locally (#9298)
Checklist
General
Motivation and Context
Recently, new Performance Guidelines were introduced. To help developers adhere to these guidelines, a script was created in this PR: #9252. The script allows for the creation of large courses locally or on test servers. These large courses can include a significant number of students and programming exercises with many student submissions. However, all of these student submissions currently result in a score of 0%. This PR addresses the issue by introducing a method for generating results that differ from 0%.
Description
A test file was added, which can either be included in the programming exercise test repository template (only if the script is used locally!). Additionally, an alternative approach was proposed for using the test file with an existing programming exercise on a test server or locally.
Steps for Testing (This PR can only be tested locally)
Prerequisites:
3.1 Run randomize_results_before.py
3.2 Start the Artemis Server and Client
3.3 Run large_course_main.py
3.4 Run randomize_results_after.py
Review Progress
Performance Review
Code Review
Manual Tests
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores