-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Improve exercise view when using LTI
#9329
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying, still works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, thanks for the work! I've got 1 small question inline and would love some clarity there ;)
this.updateVisibleNavbarItems(window.innerHeight); | ||
if (!this.anyItemHidden) this.itemsDrop.close(); | ||
if (this.itemsDrop) { | ||
this.updateVisibleNavbarItems(window.innerHeight); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the updateNavbarItems
functionality really strictly bound to the itemsDrop
? I'm not 100% certain with that functionality, thus, the question.. :)
General
: Improve exercise view when using LTI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me 👍 We can implement additional improvements in follow-up PRs
Checklist
General
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
The LTI iFrame was displaying footer, header and sidebars. Since moodle is already used to navigate the exercises we can omit most of these to get a more focused and cleaner look.
Description
The changes mainly concern the creation of a new Lti frontend service to track if the frontend is launched by LTI or not. This is used to remove unwanted elements from different components.
Steps for Testing
Prerequisites:
(If Moodle throws an error in the iFrame, just refresh the page)
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Client
Screenshots
Summary by CodeRabbit
LtiService
to manage LTI state across components.onResize
method to prevent potential issues.CourseOverviewComponent
with improved assertions and logic checks.