Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix the broken git programming submission e2e tests #9546

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Development: Fix the broken git programming submission e2e tests #9546

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4af8d23
use old and slower participation retrieval method again
SimonEntholzer Oct 21, 2024
b543f62
disable access log service and remove runAsync
SimonEntholzer Oct 21, 2024
0cace57
revert removal of AccessLogService
SimonEntholzer Oct 21, 2024
c0d510f
added throw error with information
SimonEntholzer Oct 21, 2024
0175eac
throw different exception
SimonEntholzer Oct 21, 2024
6259b32
added back old code
SimonEntholzer Oct 21, 2024
38b741d
Update src/main/java/de/tum/cit/aet/artemis/programming/service/Progr…
SimonEntholzer Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/de/tum/cit/aet/artemis/programming/service/localvc/LocalVCServletService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,11 @@ public void authorizeUser(String repositoryTypeOrUserName, User user, Programmin

ProgrammingExerciseParticipation participation;
try {
participation = programmingExerciseParticipationService.retrieveParticipationForRepository(repositoryTypeOrUserName, localVCRepositoryUri.toString());
participation = programmingExerciseParticipationService.retrieveParticipationForRepository(exercise, repositoryTypeOrUserName,
localVCRepositoryUri.isPracticeRepository(), true);

// TODO Add this back in when we have figured out what is incorrect in the playwright configuration for (MySQL, Local)
// participation = programmingExerciseParticipationService.retrieveParticipationForRepository(repositoryTypeOrUserName, localVCRepositoryUri.toString());
}
catch (EntityNotFoundException e) {
throw new LocalVCInternalException(
Expand Down
Loading