Development: Fix authorization for assetlinks.json

[FelberMartin]

Checklist

General

• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

This is a follow up to #9648, as the problem with deep links in the android app persists.

Description

I permitted access to the assetlinks.json file without the need for authentication.

Steps for testing

I deployed my changes to TS6

• Call the google API for testing the assetlinks.json file: https://digitalassetlinks.googleapis.com/v1/statements:list?source.web.site=https://artemis-test6.artemis.cit.tum.de&relation=delegate_permission/common.handle_all_urls
• See that the assetlinks.json file is returned
• Replace the testserver with a server that does not have these PR changes yet (e.g. simply replacing "...artemis-test6... "with "...artemis-test5..." in the URL parameter)
• See that there is an authentication error

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Summary by CodeRabbit

• New Features

  • Enhanced security configuration for various endpoints, allowing access to /.well-known/assetlinks.json for all users.
  • Conditional access control for the /management/prometheus/** endpoint based on client IP address.
  • Unauthenticated access to the /git/** endpoint when local version control is active.

• Bug Fixes

  • Improved handling of authentication and authorization processes for better security posture.

[coderabbitai]

Walkthrough

The SecurityConfiguration class has been modified to enhance security settings for specific endpoints. A new request matcher allows public access to /.well-known/assetlinks.json. The authorization rules for the /management/prometheus/** endpoint have been updated to include IP address-based access control. Additionally, access to the /git/** endpoint is now conditional on the local version control system's status. These changes refine the security posture without altering the overall structure of the filterChain method.

Changes

File Path	Change Summary
src/main/java/de/tum/cit/aet/artemis/core/config/SecurityConfiguration.java	- Added request matcher for /.well-known/assetlinks.json allowing public access. - Updated access control for /management/prometheus/** based on client IP addresses. - Conditional access for /git/** based on profileService.isLocalVcsActive().

Possibly related PRs

• Development: Fix content-type of /.well-known/assetlinks.json #9648: The changes in this PR involve the endpoint /.well-known/assetlinks.json, which is directly related to the modifications made in the main PR regarding access rules for this endpoint.

Suggested labels

server, client, communication

Suggested reviewers

• krusche

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test9.artemis.cit.tum.de" is already in use by PR #9759.

[PaRangger]

Change LGTM. Edit: TS6 returns json, TS5 returns error.

[cremertim]

Changes lgtm

[julian-wls]

Tested on TS1. Test server on which the code is deployed returns assetlinks.json.