Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update sentry config #9824

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Development: Update sentry config #9824

merged 4 commits into from
Dec 20, 2024

Conversation

magkue
Copy link
Contributor

@magkue magkue commented Nov 19, 2024

Checklist

General

Motivation and Context

As we had a lot of problems fixing the old sentry instances we redeployed it completely. Now we need to set a new Sentry DSN to enable Artemis to send logs to sentry (DSNs are safe to keep public, according to Sentry Docs)

Description

I updated all occurrences of the old dsn value with the new one.

Steps for Testing

On Artemis:

  1. Log in to Artemis
  2. Disable all content filter and ad blocker
  3. Open the developer tools of your browser
  4. Open the network tap & Reload the site once
  5. Search for sentry, check if all request to sentry are successful (status code 200)

On Sentry:

  1. Go to https://sentry.ase.in.tum.de/
  2. Login with TUM Credentials
  3. Check the artemis project

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Chores
    • Updated Sentry DSN values in the ProfileService test file for consistency.

@magkue magkue requested a review from a team as a code owner November 19, 2024 19:14
coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 19, 2024
@github-actions github-actions bot added tests config-change Pull requests that change the config in a way that they require a deployment via Ansible. labels Nov 19, 2024
@magkue magkue temporarily deployed to artemis-test5.artemis.cit.tum.de November 19, 2024 19:40 — with GitHub Actions Inactive
Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 19, 2024
Copy link

coderabbitai bot commented Nov 19, 2024

Walkthrough

The changes in this pull request involve updating the Sentry DSN value in the ProfileService test file. Specifically, the DSN has been changed from https://ceeb3e72ec094684aefbb132f87231f2@sentry.ase.in.tum.de/2 to https://e52d0b9b6b61769f50b088634b4bc781@sentry.ase.in.tum.de/2 in two locations within the test setup. No other modifications to logic or control flow were made.

Changes

File Change Summary
src/test/javascript/spec/service/profile.service.spec.ts Updated Sentry DSN value in serverResponse and expectedProfileInfo objects.

Suggested labels

ready for review, bugfix, core

Suggested reviewers

  • florian-glombik
  • SimonEntholzer
  • krusche
  • ole-ve

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 19, 2024
Copy link

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test5.artemis.cit.tum.de" is already in use by PR #9819.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 19, 2024
@magkue magkue added deploy:artemis-test1 and removed deployment-error Added by deployment workflows if an error occured labels Nov 19, 2024
Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3, not sure if this is related to your PR but I still get these issues in the console
image
image

Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3. Had the following

image

@magkue
Copy link
Contributor Author

magkue commented Dec 5, 2024

@BBesrour This is probably due to some ad blocker (i. e. u-block). If you disable these you should get a status code 200. I update the testing instructions.

@magkue
Copy link
Contributor Author

magkue commented Dec 5, 2024

@HawKhiem Your screenshot looks fine to me, all request are successful. Do I miss something?

@magkue magkue requested review from BBesrour and HawKhiem December 5, 2024 16:18
Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approve code

Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS5. Reapprove

@krusche krusche added this to the 7.8.0 milestone Dec 20, 2024
@krusche krusche merged commit c00d635 into develop Dec 20, 2024
54 of 56 checks passed
@krusche krusche deleted the fix/set-new-sentry-dsn branch December 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-change Pull requests that change the config in a way that they require a deployment via Ansible. ready for review tests
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

9 participants