Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Fix an issue with the access log in exam exercises #9872

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

SimonEntholzer
Copy link
Contributor

@SimonEntholzer SimonEntholzer commented Nov 26, 2024

Checklist

General

  • I tested all changes and their related features with all corresponding user types on a test server.
  • This is a small issue that I tested locally and was confirmed by another developer on a test server.
  • I chose a title conforming to the naming conventions for pull requests.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The routes for the vcsAccessLog were missing for the exam mode.

Description

This PR adds the routes for the VcsAccessLog for exam mode exercises.

Steps for Testing

Prerequisites:

  1. Log in to Artemis
  2. Create an exam with a programming exercise
  3. Add students, generate student exams and prepare exercise start
  4. Navigate to Exercise groups -> Exercise -> Participations
  5. Use the code button to navigate to the repository of the student participation (exam does not need to have started yet)
  6. Check that the Open access log button leads to the access log of the repository
  7. In the exercise overview page, access the template and solution repositories, and check that the vcs-access-log is shown for them too

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual exam mode Tests

  • Test 1
  • Test 2

Screenshots

image

@SimonEntholzer SimonEntholzer requested a review from a team as a code owner November 26, 2024 14:38
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 26, 2024
@SimonEntholzer SimonEntholzer changed the title add vcs access log paths to exam mode repos Programming exercises: Add vcs access log routing to exam mode repositories Nov 26, 2024
Copy link

coderabbitai bot commented Nov 26, 2024

Walkthrough

The changes introduce new route configurations in the exam-management.route.ts file of an Angular application. Two routes are added for the VcsRepositoryAccessLogViewComponent, allowing access to VCS access logs for specific programming exercise repositories and participations. These routes include data properties for authorities and page titles, and utilize the UserRouteAccessService and LocalVCGuard for access control. The component is also imported to ensure availability for the new routes.

Changes

File Path Change Summary
src/main/webapp/app/exam/manage/exam-management.route.ts Added two new routes for VcsRepositoryAccessLogViewComponent with access control and data properties.
src/main/webapp/app/localvc/vcs-repository-access-log-view/vcs-repository-access-log-view.component Imported VcsRepositoryAccessLogViewComponent for use in the newly defined routes.

Possibly related PRs

Suggested labels

ready for review, server, core, programming, exercise

Suggested reviewers

  • florian-glombik
  • krusche
  • egekurt123
  • pzdr7

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@muradium muradium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3, works as expected

Copy link
Contributor

@iyannsch iyannsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Code LGTM

@SimonEntholzer SimonEntholzer changed the title Programming exercises: Add vcs access log routing to exam mode repositories Programming exercises: Fix vcs access log routing in exam mode repositories Nov 26, 2024
Copy link
Contributor

@janthoXO janthoXO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3

@krusche krusche added this to the 7.7.3 milestone Nov 26, 2024
@krusche krusche changed the title Programming exercises: Fix vcs access log routing in exam mode repositories Programming exercises: Fix an issue with the access log in exam exercises Nov 26, 2024
@krusche krusche added the maintainer-approved The feature maintainer has approved the PR label Nov 26, 2024
@krusche krusche merged commit 1539df5 into develop Nov 26, 2024
46 of 50 checks passed
@krusche krusche deleted the bugfix/vcs-access-log/exam-mode-access-logs branch November 26, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) maintainer-approved The feature maintainer has approved the PR ready for review ready to merge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants