-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve feedback and some fixes #56
Conversation
@pal03377 should I also drop the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and didn't have any issue. Also I looked at the code and everything I see looks like a total improvement 💪 Good job!
id = Column(Integer, primary_key=True, index=True, autoincrement=True) | ||
detail_text = Column(String, nullable=False) | ||
text = Column(String, nullable=False) | ||
lms_id = Column(Integer, nullable=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting! Does that mean that we will be able to use one Athena instance with multiple LMSes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I see the lms_id
unique constraint. Why do we need that? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can do a combined uniqueness thingy if you want to allow multiple lms'. As of now I think we should just have one Athena instance per LMS
Let's discuss this separately from this PR |
Motivation and Context
I'm having some issues with the feedback while implementing the human evaluation mode. This branch aims to fix some of those issues and improve on the feedback schema.
Description
text
->title
anddetail_text
->description
(less confusing)Open Issues
title
from the feedback schema?Steps for Testing
Screenshots