Update team statistics on drag and drop model change #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayedrian
changed the title
Mtze
requested changes
Apr 21, 2023
|
Is this PR ready to review? |
Yes I think so. |
This was
linked to
issues
Apr 28, 2023
Mtze
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 of Dragula came with some breaking changes, one of which was that the [dragulaModel] directive no longer mutates the array that you provide it but instead returns a shallow copy of the result, to actually change/update the array (for example a team) a simple switch to the two-way binding alternative [(dragulaModel)] can be used.
Now dragging a person from one team to another or to the unassigned person pool automagically updates the team statistics (I love frontend frameworks!), so the team size and priority distribution show the correct values, and any unsatisfied constraints are highlighted in red.
What changed: Dragging and dropping a person from one team to another to manually modify the allocation now correctly updates the model to reflect a person's new team
Why the change: Without the model update manual changes don't persist -> CSV export (for example) doesn't correctly reflect the teams persons were assigned in final allocation
Testing steps: Import & load example data -> Drag and drop a student from one team to another -> Export team allocation data and check whether the column specifying the person's team matches the team the person was dragged into