Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings on Windows due to redefines #258

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

arvid-norlander
Copy link
Contributor

The defines were already set globally in our environment when building with VS2019, causing warnings due to redefines (and we treat all warnings as errors). The fix is simple, add #ifndef around the defines so they are only defined if not already defined.

@lsalzman lsalzman merged commit a356ac0 into lsalzman:master Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants