Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback term grid to 0.1 and release v1.1.2 #1019

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Mar 25, 2024

No description provided.

we should consider find another alternative

Signed-off-by: Wei Zhang <kweizh@gmail.com>
Signed-off-by: Wei Zhang <kweizh@gmail.com>
Copy link

muniu-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwpaper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (16181df) to head (62e93a9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   84.45%   84.34%   -0.11%     
==========================================
  Files          53       53              
  Lines        5108     5111       +3     
==========================================
- Hits         4314     4311       -3     
- Misses        794      800       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwpaper zwpaper merged commit 0e70dbd into lsd-rs:master Mar 25, 2024
20 of 21 checks passed
@decathorpe
Copy link
Contributor

decathorpe commented Apr 6, 2024

This is reverting part of one of my previous changes - is there a specific reason this dependency is downgraded again?

EDIT: I have now seen the referenced issue. Sorry about the regression, I didn't catch that. I agree that uutils_term_grid seems like a good / maintained alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants