-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug: Handle -L with broken symlink #457 #754
Conversation
Sorry about the delayed response. I somehow missed the PR. This looks great. Could you add tests for this behavior and a changelog entry and we should be good to go. |
Thank you for the response. I'll make those changes soon and let you know when they are ready. |
@meain I have added tests and updated the changelog, although I do not have a Windows device to run the tests. According to the Rust docs, symlink creation on the Windows OS is a privileged action, so these tests will probably fail on Windows. Should I make these tests Unix only? What are your thoughts? Thanks. |
@r3dArch The CI should be able to run Windows test. With that said, if the test are gonna fail on Windows, we can run it on just linux and macOS. |
Merging another PR causing some conflicts, could you also take care of that :D. |
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 86.60% 86.73% +0.13%
==========================================
Files 44 44
Lines 4336 4434 +98
==========================================
+ Hits 3755 3846 +91
- Misses 581 588 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@meain I fixed a clippy warning pointed out by the CI/CD and the conflicts caused by the other PR. Is there anything else needed for this to be merged? Clippy points out some other style problems, but they are not from the changes I made. |
Thanks again for the PR :D. |
Thank you. This was actually my first contribution to someone else's project, so it is really nice it got merged :D. |
To more PRs! 🍷 🍾 😉 |
This is a draft PR for #457.
TODO
cargo fmt