Disallow extend self inside of a class.

Closes gh-202
lsegal · Nov 11, 2010 · 2a5a989 · 2a5a989
1 parent 9717677
commit 2a5a989
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/lib/yard/handlers/ruby/extend_handler.rb b/lib/yard/handlers/ruby/extend_handler.rb
@@ -10,6 +10,9 @@ def scope; :class end
 
   def process_mixin(mixin)
     if mixin == s(:var_ref, s(:kw, "self"))
+      if namespace.is_a?(ClassObject)
+        raise UndocumentableError, "extend(self) statement on class"
+      end
       namespace.mixins(scope) << namespace
     else
       super

diff --git a/lib/yard/handlers/ruby/legacy/extend_handler.rb b/lib/yard/handlers/ruby/legacy/extend_handler.rb
@@ -8,6 +8,9 @@ def scope; :class end
 
   def process_mixin(mixin)
     if mixin == "self"
+      if namespace.is_a?(ClassObject)
+        raise UndocumentableError, "extend(self) statement on class"
+      end
       namespace.mixins(scope) << namespace
     else
       super

diff --git a/spec/handlers/extend_handler_spec.rb b/spec/handlers/extend_handler_spec.rb
@@ -16,4 +16,8 @@
   it "should extend module with correct namespace" do
     Registry.at('Q::R::S').class_mixins.first.path.should == 'A'
   end
+
+  it "should not allow extending self if object is a class" do
+    undoc_error "class Foo; extend self; end"
+  end
 end