Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 2.2.9 2.3.6 2.4.3 2.5.0 #1156

Merged
merged 2 commits into from
Mar 17, 2018
Merged

Use 2.2.9 2.3.6 2.4.3 2.5.0 #1156

merged 2 commits into from
Mar 17, 2018

Conversation

aycabta
Copy link
Contributor

@aycabta aycabta commented Jan 2, 2018

Description

ref. travis-ci/travis-ci#8978 (comment)

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 93.496% when pulling c0f0e07 on aycabta:use-2.2.9-2.3.6-2.4.3-2.5.0 into 87080b5 on lsegal:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 2, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 93.496% when pulling c0f0e07 on aycabta:use-2.2.9-2.3.6-2.4.3-2.5.0 into 87080b5 on lsegal:master.

lsegal
lsegal reviewed Jan 2, 2018
View reviewed changes
.travis.yml
@@ -10,6 +10,10 @@ cache: bundler
# Passes arguments to bundle install (http://gembundler.com/man/bundle-install.1.html)
# bundler_args:

before_install:
- gem update --system
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this part. Based on the ref'd ticket, can we not just wait for this to be fixed in travis so as to avoid a workaround?

@lsegal
Copy link
Owner

lsegal commented Mar 2, 2018

@aycabta I will have to close this unless we can get the comment above addressed.

@lsegal lsegal merged commit a0d3d75 into lsegal:master Mar 17, 2018
lsegal added a commit that referenced this pull request May 28, 2018
@lsegal
Tag release v0.9.13
dff428a 
References:
  #1056, #1144, #1145, #1152, #1154, #1156, #1166, #1167,
  #1168, #1169, #14256, #610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsegal lsegal lsegal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aycabta @coveralls @lsegal