Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support module_function decorator #1365

Merged
merged 1 commit into from
May 6, 2021

Conversation

mrkn
Copy link
Contributor

@mrkn mrkn commented Feb 9, 2021

Description

module_function can be used as a decorator likewise private.
This pull-request makes yard to support this feature.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

mrkn added a commit to red-data-tools/unicode_plot.rb that referenced this pull request Feb 9, 2021
The latest yard doesn't support the decorator `module_function`.
I submitted lsegal/yard#1365 to add the support of it.
We need to use mrkn/yard until the pull-request will be merged and the
new version of yard will be released.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.427% when pulling ac4cbcc on mrkn:module_function_decorator into 3590066 on lsegal:main.

@mrkn
Copy link
Contributor Author

mrkn commented Mar 1, 2021

@lsegal I'm sorry to bother you, how do you think this change? Could you merge this and release a new version?

@lsegal lsegal merged commit ebe41e1 into lsegal:main May 6, 2021
@lsegal
Copy link
Owner

lsegal commented May 6, 2021

Thanks for your PR! Sorry about not merging earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants