Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add existence check for readme #1367

Merged
merged 1 commit into from
May 6, 2021
Merged

Add existence check for readme #1367

merged 1 commit into from
May 6, 2021

Conversation

chriscz
Copy link
Contributor

@chriscz chriscz commented Feb 10, 2021

Description

This PR fixes #1366, YARD failing to parse missing symlinked file in gem.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 93.429% when pulling 2eef8f3 on chriscz:main into 3590066 on lsegal:main.

@lsegal lsegal merged commit 4e28f8a into lsegal:main May 6, 2021
@lsegal
Copy link
Owner

lsegal commented May 6, 2021

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsegal lsegal lsegal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YARD fails to parse missing symlinked file in gem
3 participants
@chriscz @coveralls @lsegal