Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute parsing #435

Merged
merged 1 commit into from
Jan 2, 2012
Merged

Fix attribute parsing #435

merged 1 commit into from
Jan 2, 2012

Conversation

avsej
Copy link
Contributor

@avsej avsej commented Dec 26, 2011

Hi guys

There is a mistype of rb_define_attr signature in regex which cause that real attribute definitions cannot be parsed. Your specs used wrong signatures, therefore all was green. This is the real signature for rb_define_attr(). There is only four arguments.

void rb_define_attr(VALUE klass, const char *name, int read, int write)

Thanks

This is the real signature for rb_define_attr(). There is only four
arguments.

    void rb_define_attr(VALUE klass, const char *name, int read, int write)
@lsegal lsegal merged commit a23b72d into lsegal:master Jan 2, 2012
@lsegal
Copy link
Owner

lsegal commented Jan 2, 2012

Thank you for fixing this. It's unfortunate that we messed this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants