JavaScript bug fix for the default template. #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the frames view in the default template, it attempts to set the page title when you load a page in the main frame. If you are serving content from disk using file://, some browsers, like Chrome, will raise an error. This stops the rest of the JavaScript on the page from running. This pull request adds a try-catch block around the window title assignment statement. In the case when this fails, the title simply is not updated.
lsegal
added a commit
that referenced
this pull request
Nov 1, 2013
JavaScript bug fix for the default template.
|
Thanks Trevor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the frames view in the default template, it attempts to set the page title when you load a page in the
main frame. If you are serving content from disk using file://, some browsers, like Chrome, will raise an error. This stops the rest of the JavaScript on the page from running.
This pull request adds a try-catch block around the window title assignment statement. In the case when this fails, the title simply is not updated.