nondecreasing export list formatting #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expipiplus1
force-pushed
the
joe-exportlist
branch
from
71aaab8 to
67b8710
Compare
|
Looks good to me! I've always wondered by Brittany formats exports lists like this in the first place. |
expipiplus1
force-pushed
the
joe-exportlist
branch
from
67b8710 to
64417c5
Compare
|
Is it possible to get this merged, please? |
|
Sure, I'll go ahead and merge this. |
|
Thanks!
…On Wed, Oct 21, 2020, 4:35 AM Taylor Fausak ***@***.***> wrote:
Merged #313 <#313> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#313 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXGJWLBBEDSVJBZPQVDSLXYBXANCNFSM4QNTQNOA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now becomes
Having the
wherealigned withmoduleis a bit weirdy IMO.Not sure if my patch is the best way to do this, I wrote it a while ago
and have forgotten how much care I put into it.
Haven't updated the tests yet either, but is this something which wouldbe merged?