Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom logdir specification #48

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Allow custom logdir specification #48

merged 1 commit into from
Apr 26, 2019

Conversation

tcbegley
Copy link
Contributor

@tcbegley tcbegley commented Apr 25, 2019

Hey,

First of all, thanks for making this project. I've found it really useful.

I have a use case where I want to specify a logging directory for Tensorboard that is outside of the current Jupyter root directory. I wasn't able to find a way to do this with the existing UI, so I made a fork and added something myself. I thought I would make a pull request in case you think it might be useful to other people.

Here's how it works. Now from the "New" menu in Jupyter you can select either Current Directory or Custom Directory:

image

Selecting Custom Directory brings up a modal with a text field into which any path can be entered

image

This creates the Tensorboard instance with the supplied path being used as the logging directory.

The main thing missing at the moment I would say is that it doesn't do any validation on the filepath supplied by the user, so for example you can create a Tensorboard instance that uses a non-existent directory as its logging directory (maybe that's useful if the directory gets created during model training or something?).

Other things: maybe rather than the dropleft submenu, there should just be another section to the original dropdown titled "Tensorboard", like there currently is "Notebooks" and "Other". Also I didn't add any tests, but it's probably worth doing so. Happy to take guidance on that.

Happy for you to say whether you think any of those are important to add or whether they can wait to a future update.

Anyway, let me know if you think this is something that's worth adding.

@lspvic lspvic merged commit 6cfc24c into lspvic:master Apr 26, 2019
@lspvic
Copy link
Owner

lspvic commented Apr 26, 2019

Thanks for you contribution!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants