Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SymFiniteBits interface #262

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Improve SymFiniteBits interface #262

merged 1 commit into from
Nov 9, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Nov 9, 2024

This pull request makes symCountLeadingZeros/symPopCount/symCountTrailingZeros less confusing by returning the arg type. Previously, it will return a literal value when we return a dynamic-sized bit vector (SomeBV) without the bit-width assigned. This can be confusing and is very hard to debug.

This pull request ensures that the bit-width is always adequately assigned.

@lsrcz lsrcz added the bug Something isn't working label Nov 9, 2024
@lsrcz lsrcz self-assigned this Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.74%. Comparing base (6dd4e9b) to head (318d91f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...isette/Unified/Internal/Class/UnifiedFiniteBits.hs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   54.67%   54.74%   +0.06%     
==========================================
  Files         121      121              
  Lines       12914    12914              
  Branches      910      907       -3     
==========================================
+ Hits         7061     7070       +9     
+ Misses       4943     4937       -6     
+ Partials      910      907       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 9946b6b into main Nov 9, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant