Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new derivation mechanism supporting GADTs #267

Merged
merged 63 commits into from
Dec 29, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Dec 29, 2024

A lot of changes has been done in this pull request. Notably:

  • The deriveGADT template haskell procedure now derive all relevant instances for GADTs, and the old TH derivation mechanism has been removed.
  • Added EvalModeConvertible for a unified constraint for the evaluation modes that can be converted to each other with ToCon and ToSym.
  • We no longer support direct toCon from a union to a single value or toSym from a single value to a union. These should now be done through mrgToSym, toUnionSym, and unionToCon.
  • Changed the EvalMode tag for Con to C and Sym to S.
  • Fixed some missing constraints for unified interfaces.
  • Fixed badly staged types in the lifting of terms.
  • Fixed the Read instance for bit-vectors on GHC 9.12.

lsrcz added 30 commits December 18, 2024 09:27
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 42.72959% with 898 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (14f4c81) to head (d109fdb).
Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
...e/Internal/Internal/Impl/Core/Data/Class/PPrint.hs 11.94% 96 Missing and 22 partials ⚠️
...nternal/Internal/Impl/Core/Data/Class/Mergeable.hs 43.87% 78 Missing and 9 partials ⚠️
...Internal/Internal/Impl/Core/Control/Monad/Union.hs 49.38% 68 Missing and 14 partials ⚠️
...e/Internal/Internal/Decl/Core/Data/Class/PPrint.hs 44.28% 43 Missing and 35 partials ⚠️
...ternal/Internal/Impl/Core/Data/Class/ExtractSym.hs 12.34% 54 Missing and 17 partials ⚠️
.../Internal/Internal/Impl/Core/Data/Class/EvalSym.hs 30.66% 41 Missing and 11 partials ⚠️
...l/Internal/Impl/Core/Data/Class/SimpleMergeable.hs 57.72% 50 Missing and 2 partials ⚠️
...e/Internal/Internal/Decl/Core/Data/Class/Solver.hs 20.63% 47 Missing and 3 partials ⚠️
...nternal/Internal/Decl/Core/Data/Class/Mergeable.hs 60.86% 27 Missing and 9 partials ⚠️
...te/Internal/Internal/Decl/Core/Data/Class/SymEq.hs 18.18% 20 Missing and 7 partials ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #267       +/-   ##
===========================================
+ Coverage   54.65%   75.23%   +20.57%     
===========================================
  Files         122      209       +87     
  Lines       12936    30947    +18011     
  Branches      906     2189     +1283     
===========================================
+ Hits         7070    23282    +16212     
- Misses       4960     5476      +516     
- Partials      906     2189     +1283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz force-pushed the feat-gadt-all-instances branch from 702d423 to 7ac7bae Compare December 29, 2024 07:46
@lsrcz lsrcz force-pushed the feat-gadt-all-instances branch from 25e3088 to 816d85a Compare December 29, 2024 13:50
@lsrcz lsrcz merged commit 5635565 into main Dec 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant