Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old poe-api cause AttributeError #1081 #1097

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

qrzbing
Copy link
Contributor

@qrzbing qrzbing commented Jul 29, 2023

fix #1081

@Haibersut Haibersut merged commit 7240afb into lss233:browser-version Jul 31, 2023
@Haibersut
Copy link
Collaborator

thx

@qrzbing
Copy link
Contributor Author

qrzbing commented Jul 31, 2023

但是我看了一下 action,没有正确推到 dockerhub 上。。。虽然前面安装了 build-essential,但是后面 build quickjs 的时候还是没有找到 gcc,难道是环境变量问题?

@qrzbing
Copy link
Contributor Author

qrzbing commented Jul 31, 2023

哦我知道了,在 Dockerfile 里面安装完了之后把 binutils 卸载了,这一步顺便把 gcc 也卸载了。不知道作者卸载 binutils 的目的是啥,减少 Docker 的大小吗

@Haibersut
Copy link
Collaborator

Haibersut commented Jul 31, 2023

不知道,docker不是我写的,我刚才才看到构建失败(

要的话也应该是装完依赖再卸载吧

@Haibersut
Copy link
Collaborator

感觉可以这样

RUN apt-get update && \
    apt install --no-install-recommends xvfb binutils build-essential qtbase5-dev wkhtmltopdf ffmpeg -yq && \
    (strip --remove-section=.note.ABI-tag /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 || true) && \
    apt-get clean && \
    apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false && \
    rm -rf /var/lib/apt/lists/*

RUN mkdir -p /app
WORKDIR /app

COPY requirements.txt /app
RUN pip install --no-cache-dir -r requirements.txt && pip cache purge

RUN apt-get remove --purge -yq binutils

@qrzbing
Copy link
Contributor Author

qrzbing commented Jul 31, 2023

我觉得可以,我先跑个 action 试试

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AttributeError: 'NoneType' object has no attribute 'group'
2 participants