DM-46034: Fix implementation of use-cache #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fromJSON` trick to force a boolean argument to a boolean appears to not work based on GitHub Actions output for safir and (in the case of run-tox, which has the same construction) Gafaelfawr. Compare use-cache against a string 'true' instead, which is reported to work correctly.
|
Tested with Safir. Compare workflow runs https://github.com/lsst-sqre/safir/actions/runs/10692720827/job/29641658832 (fixed) and https://github.com/lsst-sqre/safir/actions/runs/10667368211/job/29641353960 and notice how the latter still restored the cache, but the former did not. See actions/runner#2238 for more details. |
rra
force-pushed
the
tickets/DM-46034
branch
from
f7c0c29
to
caacf22
Compare
|
New test using the same construction as build-and-publish-to-pypi: https://github.com/lsst-sqre/safir/actions/runs/10704089751/job/29676203060 |
Booleans were working correctly with the build-and-publish-to-pypi
action, so use the same construction that was used there. Perhaps
the interpolation using ${{}} or the lack of a comparison was
creating the problem.
rra
force-pushed
the
tickets/DM-46034
branch
from
caacf22
to
09fcc65
Compare
jonathansick
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the
fromJSONtrick to force a boolean argument to a boolean was used here appears to have stopped working (or perhaps hadn't worked before?) based on GitHub Actions output for safir and (in the case of run-tox, which has the same construction) Gafaelfawr. Make the construction match what https://github.com/lsst-sqre/build-and-publish-to-pypi does which seems to work better.