Implement Control Location IP permissions #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/LOVE-198
branch
from
0f58121
to
1ff98e2
Compare
areyesd14
reviewed
Jun 22, 2023
areyesd14
reviewed
Jun 22, 2023
areyesd14
approved these changes
Jun 22, 2023
* Change HTTP.status_codes to 403 * Change denied permission request payload * Refactor patching of os.environ to avoid strange behavior
sebastian-aranda
force-pushed
the
tickets/LOVE-198
branch
from
7b1df58
to
8109841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes an extension to be able to configure the type of base permission to use, one of:
userorlocation. Ifuseris selected then the current permission system will be used, iflocationis used then location based permissions will be aplied.