Manager performance improvements #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.rst
Outdated
| @@ -5,6 +5,7 @@ Version History | |||
| v5.14.11 | |||
There was a problem hiding this comment.
I have one question, should this be a minor change? I think on the change of daphne per uvicorn... should that affect on the numeration?
There was a problem hiding this comment.
If the outward appearance of the application has not changed, then a minor version is fine. Internals are allowed to changed within that context.
There was a problem hiding this comment.
this is a simple and great explanation! gotcha 👍.
There was a problem hiding this comment.
The minor version is the second number in the semver. The last number is the patch version. The server replacement warrants a minor not a patch level change.
There was a problem hiding this comment.
thanks for catching this, it almost missed that.
mareuter
approved these changes
Nov 16, 2023
sebastian-aranda
force-pushed
the
tickets/DM-41588
branch
from
724ff24 to
e44ff0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a couple configurations on the LOVE-manager service:
daphneperuvicorna lightweight fast python ASGI server as it reduces memory use considerably.group_expirychannels_redis configuration to big limit so no initial_state channels are being erased for non activity. See DM-41728.Also the remote storage feature was fixed.