Add M1M3 bump tests reports endpoint #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/DM-42550
branch
from
8459aaa to
c01c661
Compare
pkubanek
reviewed
Jan 29, 2024
| @@ -547,7 +562,10 @@ def salinfo_topic_names(request): | |||
| query = "" | |||
| if "categories" in request.query_params: | |||
| query = "?categories=" + request.query_params["categories"] | |||
| url = f"http://{os.environ.get('COMMANDER_HOSTNAME')}:{os.environ.get('COMMANDER_PORT')}/salinfo/topic-names{query}" | |||
| url = ( | |||
| f"http://{os.environ.get('COMMANDER_HOSTNAME')}:" | |||
There was a problem hiding this comment.
Is there a way to add https somehow? Can that be an ENV variable?
pkubanek
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
reports/m1m3-bump-testsendpoint in order to query the new app of the LOVE-commander: lsst-ts/LOVE-commander#66.Also several
pre-commitwarnings were fixed.