Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
cvillalon committed Nov 5, 2024
1 parent ca453fb commit cbb4c86
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 3 additions & 2 deletions python/lsst/ts/standardscripts/maintel/mtdome/home_dome.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ async def configure(self, config):

if self.mtcs is None:
self.mtcs = MTCS(
domain=self.domain, intended_usage=MTCSUsages.Slew, log=self.log
domain=self.domain,
intended_usage=MTCSUsages.Slew | MTCSUsages.StateTransition,
log=self.log,
)
await self.mtcs.start_task

Expand All @@ -104,7 +106,6 @@ def set_metadata(self, metadata):
metadata.duration = self.home_dome_duration

async def run(self):
await self.mtcs.enable()
await self.mtcs.assert_all_enabled()
await self.checkpoint("Homing dome")
await self.mtcs.home_dome(physical_az=self.physical_az)
2 changes: 0 additions & 2 deletions tests/test_maintel_mtdome_home_dome.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ async def basic_make_script(self, index):
async def make_dry_script(self):
async with self.make_script(self):
self.script.mtcs = unittest.mock.AsyncMock()
self.script.mtcs.enable = unittest.mock.AsyncMock()
self.script.mtcs.assert_all_enabled = unittest.mock.AsyncMock()
self.script.mtcs.home_dome = unittest.mock.AsyncMock()
yield
Expand All @@ -50,7 +49,6 @@ async def test_run(self):
await self.configure_script(physical_az=300.0)

await self.run_script()
self.script.mtcs.enable.assert_awaited_once()
self.script.mtcs.assert_all_enabled.assert_awaited_once()
self.script.mtcs.home_dome.assert_awaited_once()
self.script.mtcs.home_dome.assert_called_with(physical_az=300.0)
Expand Down

0 comments on commit cbb4c86

Please sign in to comment.