Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickets/DM-46309: Add open and close mirror covers SAL scripts for MT #234

Merged
merged 2 commits into from
Oct 21, 2024
Merged

tickets/DM-46309: Add open and close mirror covers SAL scripts for MT #234

merged 2 commits into from
Oct 21, 2024

Conversation

cvillalon
Copy link
Contributor

No description provided.

tribeiro
tribeiro approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I do have a couple inline comments I hope you will consider before merging.

python/lsst/ts/standardscripts/maintel/close_mirror_covers.py Outdated Show resolved Hide resolved
python/lsst/ts/standardscripts/maintel/close_mirror_covers.py Show resolved Hide resolved
python/lsst/ts/standardscripts/maintel/open_mirror_covers.py Outdated Show resolved Hide resolved
python/lsst/ts/standardscripts/maintel/open_mirror_covers.py Show resolved Hide resolved
tests/test_maintel_close_mirror_covers.py Outdated Show resolved Hide resolved
tests/test_maintel_open_mirror_covers.py Outdated Show resolved Hide resolved
@cvillalon cvillalon merged commit c2956c3 into develop Oct 21, 2024
2 checks passed
@cvillalon cvillalon deleted the tickets/DM-46309 branch October 21, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribeiro tribeiro tribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvillalon @tribeiro