Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 46978 #241

Merged
merged 18 commits into from
Nov 5, 2024
Merged

Tickets/dm 46978 #241

merged 18 commits into from
Nov 5, 2024

Conversation

tribeiro
Copy link
Member

@tribeiro tribeiro commented Nov 4, 2024

No description provided.

gmegh and others added 16 commits November 4, 2024 11:25
@gmegh @tribeiro
Fix instrument to ComCam in take_aos_sequence.py
b8a0131
@tribeiro
In maintel/focus_sweep_comcam, add StateTransition to ComCam Usages.
881cc5d
@gmegh @tribeiro
Fix take_aos_sequence so intra has negative focusZ and extra positive…
534f4b9 
… focusZ
@gmegh @tribeiro
Fix current position in take_aos_sequence
89a407e
@tribeiro
Update maintel/take_image_lsstcam to sdd option to setup Guider ROI.
625d826
@tribeiro
Update maintel/take_image_lsstcam to sdd option to setup Guider ROI.
ef40a07
@gmegh @tribeiro
Add OCPS option to base_close_loop.py script
700d48e
@gmegh @tribeiro
Fix use_ocps in wep_config for base_close_loop.py
5063d6c
@gmegh @tribeiro
In base_close_loop.py fix units of hexapod offsets and intra/extra sign
dfbcae0
@tribeiro
In maintel/base_close_loop, take_intra_extra_focal_images to wait for…
fb64a68 
… images to be ingested before returning.
@tribeiro
In maintel/close_loop_comcam.py, add new oods property.
224d2c7
@tribeiro
In maintel/close_loop_lsstcam.py, add new oods property.
fb57ea3
@tribeiro
In maintel/take_aos_sequence_comcam.py, update take_aos_sequence to w…
9521a30 
…ait for images to be ingested in OODS before sending request to the OCPS.
@gmegh @tribeiro
Add infocus image in closed_loop script
80711b4
@gmegh @tribeiro
Fix in laser_tracker/align.py comparison for tolerance
8490812
@tribeiro
In maintel/apply_dof, fix configure method to skip parameters that ar…
f87ff02 
…e not DOFName.t
dsanmartim
dsanmartim approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@dsanmartim dsanmartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. There was just a typo in one of the news fragments.

doc/news/DM-46978.feature.2.rst Outdated
@@ -0,0 +1 @@
Update maintel/take_image_lsstcam to sdd option to setup Guider ROI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdd --> add

@tribeiro tribeiro merged commit 63a917e into develop Nov 5, 2024
2 checks passed
@tribeiro tribeiro deleted the tickets/DM-46978 branch November 5, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanmartim dsanmartim dsanmartim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tribeiro @dsanmartim @gmegh