Tell how to avoid bind collisions. #970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 362 362
Lines 48288 48288
Branches 5872 5872
=======================================
Hits 43155 43155
Misses 3718 3718
Partials 1415 1415 ☔ View full report in Codecov by Sentry. |
timj
reviewed
Mar 3, 2024
| @@ -168,6 +168,7 @@ filter query results based on that property of datasets. | |||
|
|
|||
| Registry methods accepting user expressions also accept a ``bind`` parameter, which is a mapping from identifier name to its corresponding value. | |||
| Identifiers appearing in user expressions will be replaced with the corresponding value from this mapping. | |||
| Choose bind identifiers that are distinct and not the same as a dimension or dimension attribute name. | |||
There was a problem hiding this comment.
The second half of this comment is only true if the dimension attribute is an integer or string and it gets promoted to be a dimension at some point in the future... Floating point attributes can't become dimensions. I realize it's easy to tell people never to do it though.
timj
force-pushed
the
u/ktl/clarify-bind-ids
branch
from
b50ef8c
to
d8ca1f7
Compare
timj
force-pushed
the
u/ktl/clarify-bind-ids
branch
from
d8ca1f7
to
eb1fd68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes