Update lstoll/oidc #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version, for JWT access tokens and PKCE. Plus, it has a bundled static client manager - just use that, and drop the local one.
Serve up some info about the user, including an avatar. This will be used by various services to collect profile info.
sr
approved these changes
Mar 9, 2024
| @@ -11,11 +11,12 @@ require ( | |||
| github.com/google/uuid v1.6.0 | |||
| github.com/justinas/nosurf v1.1.1 | |||
| github.com/lstoll/cookiesession v0.0.0-20240302214249-23c5d01c3fb9 | |||
| github.com/lstoll/oidc v0.0.0-20240302161652-ec893a64705d | |||
| github.com/lstoll/oidc v1.0.0-alpha.1 | |||
There was a problem hiding this comment.
when I stop fucking around lol
| } | ||
| if len(c.RedirectURL) == 0 { | ||
| return fmt.Errorf("issuer %s client %d must set at least one redirectURLs", parsed, ii) | ||
| } |
There was a problem hiding this comment.
Would be nice to validate early still; could this call IsValidClientID etc at the end?
There was a problem hiding this comment.
redirect URL isn't always needed - I'll add some better validation to the upstream library.
Add userinfo endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version, for JWT access tokens and PKCE. Plus, it has a bundled static client manager - just use that, and drop the local one.