Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update const tracking algorithm and APIs #1

Conversation

chunnienc
Copy link
Collaborator

@chunnienc chunnienc commented Oct 10, 2023

  • Const tracking algorithm now compares values
    • It is required to have at least a tracker for each const in pattern_args, even if we don't want it to appear in the boundary attr dict. So that the replaced gm can be updated with the new scalar input
    • See implementation for details and specs
  • Pattern now cannot take kwargs. All pattern args should be positional.

@lsy323 lsy323 merged commit 8dcfbec into lsy323:lsiyuan/op-boundry-annotation Oct 10, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants