V2 #1
Open
V2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdziat
requested changes
May 17, 2024
clean/clean.go
Outdated
| } | ||
|
|
||
| func CleanRepos(untaggedOnly bool, keepLastCount int, profile string, region string, dryRun bool, verbose bool) bool { | ||
| arnmap := map[string]string{ |
There was a problem hiding this comment.
So you would like the user to input their own arn for the role to use?
There was a problem hiding this comment.
yea, fine for it to default or use a template to update it. But if we ever add accounts it would be easier to update a mapping than it would be to push a code change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecr-cleanup ground up rework